os/: Update Kernel binary and app binary test for bk7239n #7098
Conversation
Current test code considers about kernel/common/app1 partition, not about app2 partition. This commit has been modified to enable testing even when app2 partition present. Signed-off-by: Jaeyong Lee <jaeyong1.lee@samsung.com>
|
This is for OTA test for beken chipset and includes changes done by [jylee9613] for app2 binary support in test. These are verified on both chipsets; bk7239n and rtl8721csm. |
|
Can you test this example is also verified for rtl8730e? |
verified on ailite board. |
|
Added new commit for kernel_update test for new_version. |
| if (bin_names[i] == KERNEL) { | ||
| version_up = true; | ||
| } | ||
| int version_up = true; |
There was a problem hiding this comment.
I set version_up to true only for kernel, because this is kernel update test.
What I intended is that even if only kernel binary is updated, binary manager should load the latest version of kernel and same version of app1/app2.
app1/app2 version update test need to be tested in loadable_sample/wifiapp/binary_update.c
There was a problem hiding this comment.
Got it. I have removed the changes version_up = true related chages.
namanjain7
force-pushed
the
kernel_bin_pr
branch
from
019ee42 to
ee5fc77
Compare
| uint8_t bin_types[] = {BINARY_KERNEL, BINARY_USERAPP, BINARY_USERAPP}; | ||
| #endif | ||
|
|
||
| int bin_count = sizeof(bin_names) / sizeof(bin_names[0]); |
There was a problem hiding this comment.
For safer usage, use static variable.
| int bin_count = sizeof(bin_names) / sizeof(bin_names[0]); | |
| static int bin_count = sizeof(bin_names) / sizeof(bin_names[0]); |
| /* Get info all test. */ | ||
| binary_update_getinfo_all(); | ||
|
|
||
| int ret = binary_update_same_version_test(); |
There was a problem hiding this comment.
We're printing test result inside binary_update_same_version_test.
How about change code like binary_update_run_tests.
Same for below tests too.
else if (argc == 2 && !strncmp(argv[1], "same_version", 13)) {
binary_update_getinfo_all();
return binary_update_same_version_test();
}
There was a problem hiding this comment.
You mean success message of the tests are not required because it is already getting printed inside their respective functions?
There was a problem hiding this comment.
Yes. Same as upper binary_update_run_tests case.
…rnel update test to accept command line arguments - Add support for running specific tests: same_version, new_version, invalid, all - Each test now runs independently with proper error handling - Update main function to parse argc/argv and call appropriate test functions
… update tests separately This commit modifies the wifiapp to allow users to run individual binary update tests instead of only running all tests together
namanjain7
force-pushed
the
kernel_bin_pr
branch
from
ee5fc77 to
a54fd0c
Compare
|
Requested changes done. kindly merge. |
5 participants
No description provided.